fix: catch panics from EC point creation (e.g. the point is at infinity)#4790
Merged
TomAFrench merged 5 commits intonoir-lang:masterfrom Apr 15, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Presently noir programs panic when trying to add points not in the curve.
For example:
Summary*
Ideally we would check if one of the operands to the ec addition is the point at infinity and return the other operand if so. This at least prevents it from panicking and returns a nicer error.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.